fix: clear stale overflow-read state and return corrupt on mismatch#6324
Open
ongyimeng wants to merge 2 commits intotursodatabase:mainfrom
Open
fix: clear stale overflow-read state and return corrupt on mismatch#6324ongyimeng wants to merge 2 commits intotursodatabase:mainfrom
ongyimeng wants to merge 2 commits intotursodatabase:mainfrom
Conversation
ongyimeng
force-pushed
the
investigate-btree-overflow-read-panic
branch
from
beb28e9 to
fe10f98
Compare
![turso-bot[bot]](https://avatars.githubusercontent.com/in/2434523?s=60&v=4){kind=small}
Contributor
Author
|
@LeMikaelF tagging you here as well since you replied on the original issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix an intermittent overflow-read panic in the sync parallel writes repro.
Root cause:
process_overflow_read()could resume using staleread_overflow_stateafter the cursor context changed. In that case, overflow reading could continue against the wrong record state, which could lead to a panic.What changed:
read_overflow_stateon additional cursor reposition pathsCorruptinstead of panicking when an overflow-chain mismatch is detectedValidation:
Because this issue is intermittent, I validated it by running the repro command in a loop.
BusyfailureMotivation and context
#6108
Description of AI Usage
Used AI to help investigate the panic, reason about the stale overflow-read state path, and draft the fix and validation approach. All code changes and conclusions were reviewed and validated with repeated repro runs.