scope ParseSchema by object type to avoid duplicate trigger execution#6326
Open
g0ldyy wants to merge 1 commit intotursodatabase:mainfrom
Open
scope ParseSchema by object type to avoid duplicate trigger execution#6326g0ldyy wants to merge 1 commit intotursodatabase:mainfrom
g0ldyy wants to merge 1 commit intotursodatabase:mainfrom
Conversation
Contributor
Fossier: Approved by MaintainerApproved by |
Collaborator
|
/fossier approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParseSchemaafterCREATE VIEWtotype = 'view'Reproduction
Expected SQLite result:
Before this patch, Turso returned:
Simulator
This PR extends the deterministic simulator with a targeted memory regression:
runner::memory::view_trigger_parse_schema::sim_create_view_does_not_duplicate_same_named_triggerIt verifies the sequence under simulated async I/O and after reopen to ensure the duplicated trigger execution does not persist.
Tests
cargo test -q -p core_tester --test integration_tests trigger::test_create_view_does_not_duplicate_same_named_trigger -- --exact --nocapturecargo run -q -p test-runner -- run testing/sqltests/tests/views.sqltestcargo test -q -p limbo_sim runner::memory::view_trigger_parse_schema::sim_create_view_does_not_duplicate_same_named_trigger -- --exact --nocapture