fix: spurious sqlite_stat1 NULL-idx rows emitted by ANALYZE#6347
Open
techytoes wants to merge 3 commits intotursodatabase:mainfrom
Open
fix: spurious sqlite_stat1 NULL-idx rows emitted by ANALYZE#6347techytoes wants to merge 3 commits intotursodatabase:mainfrom
techytoes wants to merge 3 commits intotursodatabase:mainfrom
Conversation
![turso-bot[bot]](https://avatars.githubusercontent.com/in/2434523?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make ANALYZE stop emitting the table-level sqlite_stat1(tbl, NULL, stat) row for indexed tables. Turso was inserting it unconditionally, unlike SQLite. Added a focused regression test for the reported repro.
Motivation and context
This is a planner-statistics correctness bug. Indexed tables should only get index stat rows here, matching SQLite.
Closes #6299