MVCC: remap root page ids so that we don't miss rows on recovery#6361
Open
pedrocarlo wants to merge 5 commits intotursodatabase:mainfrom
Open
MVCC: remap root page ids so that we don't miss rows on recovery#6361pedrocarlo wants to merge 5 commits intotursodatabase:mainfrom
pedrocarlo wants to merge 5 commits intotursodatabase:mainfrom
Conversation
Merging this PR will improve performance by 15.17%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | format_float_zero |
1,107.2 ns | 961.4 ns | +15.17% |
Comparing pedrocarlo:remap-ids (5c675c2) with main (4c8390b)
Footnotes
-
105 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm not that aware of how exactly MVCC recovery is supposed to work, but it seems that it relies on the
root_pagevalues to recover the logical log. However, it seems there is some way that we can divergetable_idsin the log file and in-memory so this code just attempts at making sure we use the same table ids to avoid losing rows.Currently rebased on top of #6342
Motivation and context
Fix panics and losing rows.
Description of AI Usage
Did the reproducers first with AI and then explored the fix with AI as well