Fix deferred FK mismatch on savepoint release#6362
Open
pedrocarlo wants to merge 2 commits intotursodatabase:mainfrom
Open
Fix deferred FK mismatch on savepoint release#6362pedrocarlo wants to merge 2 commits intotursodatabase:mainfrom
pedrocarlo wants to merge 2 commits intotursodatabase:mainfrom
Conversation
fefe915 to
ee25024
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
release_savepointandrollback_to_newest_savepointincore/storage/pager.rsto locate and remove the most-recentStatementsavepoint viarpositionand update parent offsets correctly, and only truncate the subjournal when appropriate.core/translate/fkeys.rsby removing the NEW-key probe fromemit_fk_parent_pk_change_countersand keeping NEW-key reconciliation in the REPLACE-specific path, avoiding over-decrements of the deferred-FK counter.release_root_named_savepoint_checks_deferred_fkintests/fuzz/savepoint.rsthat asserts parity with SQLite for releasing a root named savepoint that triggers deferred FK failures.Motivation and context
Description of AI Usage
Generated with codex