Skip to content

fix: filter toasts/heights by position in toast to expand toasts grou…#48

Open
marcjulian wants to merge 1 commit into
tutkli:masterfrom
marcjulian:fix/expand-toast-position
Open

fix: filter toasts/heights by position in toast to expand toasts grou…#48
marcjulian wants to merge 1 commit into
tutkli:masterfrom
marcjulian:fix/expand-toast-position

Conversation

@marcjulian

Copy link
Copy Markdown
Contributor

…ped by position

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Closes #47

What is the new behavior?

  • ToastComponent only has access to other toasts/heights in the same position group
  • track position for HeightT for filter
  • pass the correct position to the ToastComponent

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expands toasts with different positions

1 participant