Bugfix member months grain#918
Closed
davidshimamoto wants to merge 3 commits into
Closed
Conversation
|
❌ SQLFluff Linting Failed Issues were found that require manual correction or are unfixable by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
member_monthsbreaks when a person with multiple plan memberships is fed into the input layer eligibility file. Becausemember_idis part of the model, this results in multiple rows perperson_id. To fix this, I nulled outmember_id, and applied an aggregate to the eligibility data as it's staged for member months to get it to the correct grain.How has this been tested?
Ran the model with synthetic data that simulates the problem.
Reviewer focus
Note that
tuva_last_runhas been omitted, but this field is not used anywhere, so it was not needed.Checklist before requesting a review
tuva_last_runto the final outputPackage release checklist
dbt_project.yml(Optional) Gif of how this PR makes you feel
Loom link