Ensure element exists before accessing dropdown#41405
Closed
saitho wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for opening a PR, @saitho. I haven’t reviewed the changes in detail yet, but just a quick heads-up:
|
Member
|
Closing this for now. Feel free to leave a comment if you'd like us to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor check if the toggle element can be found, before using it to get or create the dropdown instance.
Motivation & Context
We're using dropdowns in our main menu which slightly differs from the expectedBootstrap markup.
When closing the dropdown via Escape key, that triggers a JavaScript error as the element Bootstrap is looking for is not present in our code.
Type of changes
Checklist
npm run lint)Live previews
Related issues