Fix twxs#69: correcting the dictionary keywords - #70
Open
ruilvo wants to merge 3 commits into
Open
Conversation
herandol
added a commit
to herandol/vs.language.cmake
that referenced
this pull request
May 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This pull request is my attempt at solving the issue #69 that I raised.
I mashed together the original dictionary file and the previous commit ones, and added a couple missing keywords, like some Qt-related stuff and the keyword
YESthat was missing for some reason, whileNOwas in there.I had to update some of the required packages to make it build, not sure if you'll be okay with that. Either way, I have built the .vsix and I have it on the releases section on my repo if you wanna give it a try for yourself and see the differences.
I'm making this pull request upstream because I hope this can benefit everybody.
Thanks for your work!