Replace untyped projectedFlowData with explicit typed variables in MonthlyFlow.vue#130
Closed
Copilot wants to merge 2 commits intomid_extreme_chartsfrom
Closed
Replace untyped projectedFlowData with explicit typed variables in MonthlyFlow.vue#130Copilot wants to merge 2 commits intomid_extreme_chartsfrom
projectedFlowData with explicit typed variables in MonthlyFlow.vue#130Copilot wants to merge 2 commits intomid_extreme_chartsfrom
Conversation
Co-authored-by: cstephen <2566292+cstephen@users.noreply.github.com> Agent-Logs-Url: https://github.com/ua-snap/hydroviz/sessions/55a79d30-9d61-49af-b829-0dcc361e4ab3
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on hydrograph and monthly flow charts PR
Replace untyped Mar 26, 2026
projectedFlowData with explicit typed variables in MonthlyFlow.vue
Contributor
|
Closing this without merging. It fixed the type of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
projectedFlowDatawas inferred asanydue to being initialized as[]in one branch and an object in another, making API shape mismatches invisible to the compiler.Changes
constvariables, each scoped to its context:projectedFlowDataMid: number[]projectedFlowDataExtremes: Record<string, number[]>let+ imperativeif/else— both fall back to an empty value when not in the matching context and are only accessed within their respective branch📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.