Add Builder pattern to AuthContext#275
Open
partha-uber wants to merge 2 commits into
Open
Conversation
Addresses review feedback from PR #271 — the growing list of nullable constructor parameters makes call sites confusing and error-prone. The new AuthContext.Builder provides a fluent API while preserving full backward compatibility with the existing data-class constructor. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builderclass toAuthContextthat provides a fluent API for constructing instances, addressing the review feedback from PR Forward optional nonce on /authorize request #271 about the growing list of nullable constructor parameters being confusing and error-prone.Closes follow-up from #271 (comment)
Test plan
AuthProviderTesttests passAuthContext Builder produces equivalent result to constructorAuthContext Builder defaults match constructor defaults./gradlew :authentication:testpasses in CI🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com