Top-down hierarchical - #814
Draft
harrisonliew wants to merge 9 commits into
Draft
Conversation
harrisonliew
requested review from
CarrotcakeInDenial,
dpgrubb13,
jerryz123 and
kenhoberkeley
October 27, 2023 03:53
harrisonliew
force-pushed
the
top_down_hier
branch
from
October 27, 2023 21:28
ea4acf1 to
f795d36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the top-down hierarchical flow in Innovus. Users are required to use a channel-based methodology, because feedthrus are not yet supported. Some notes:
vlsi.inputs.hierarchical.modewas purely dynamically-set. Hence, user setting it to "hierarchical" didn't actually do anything. I've repurposed this to be user-facing to be able to select between bottom-up and top-down flows.vlsi.inputs.hierarchical.module_mode. A similar dynamically-set key isvlsi.inputs.hierarchical.partitioning, which is needed to know if we are traversing up or down the dependency graph.par.in/outputs.in/output_dbsare added and are also dynamically set.Note: currently, this flow requires a full top-level synthesis; however, to make it more practical for agile methodologies, we will need to implement hierarchical synthesis as well. The inputs to the flow would start from leaf node synthesis in a bottom-up fashion to top-level synthesis, then top-down to bottom-up traversal of par.
A major additional change is making the Makefile generation much more DRY (see the total rewrite of
hammer_build_systems.py). Also closes #616.TODOs before merging:
Related PRs / Issues
Type of change:
Impact:
Contributor Checklist:
masteras the base branch?poetry.lockfile if you updated the requirements inpyproject.toml?e2e/if this feature depends on updated plugins?