fix: restrict peer dependency ranges to avoid npm resolution conflicts#7593
Open
MaxenceMouchard wants to merge 2 commits intoueberdosis:mainfrom
Open
fix: restrict peer dependency ranges to avoid npm resolution conflicts#7593MaxenceMouchard wants to merge 2 commits intoueberdosis:mainfrom
MaxenceMouchard wants to merge 2 commits intoueberdosis:mainfrom
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: eaf90cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
Fixes dependency resolution conflicts that occur when all Tiptap packages are pinned to the same version (e.g. 3.19.0).
Several packages currently declare peer dependencies such as "@tiptap/core": "^3.19.0", which allows npm to resolve newer versions of @tiptap/core (e.g. 3.20.x). Those newer versions may require newer peer dependencies such as "@tiptap/pm": "^3.20.x", causing an ERESOLVE unable to resolve dependency tree error when the project intentionally pins @tiptap/pm to 3.19.0.
This PR aligns peer dependency ranges between Tiptap packages so that installations remain consistent when all packages are pinned to the same version.
Implementation Approach
Updated peer dependency ranges across affected packages to ensure they remain compatible when the ecosystem is installed with synchronized versions. The goal is to prevent npm from resolving newer incompatible versions when a project intentionally locks all Tiptap packages to a specific version.
Testing Done
Tested by creating a project with all Tiptap packages pinned to version 3.19.0 and running npm install.
Before this change, npm fails with:
ERESOLVE unable to resolve dependency tree
After applying the peer dependency adjustments, npm install resolves the dependency tree successfully.
Verification Steps
Create a project and pin all Tiptap packages to 3.19.0.
Run npm install.
Verify that npm resolves dependencies without ERESOLVE errors.
Additional Notes
Multiple issues in the repository report similar dependency resolution problems when pinning Tiptap packages to a fixed version.
While investigating this, I also noticed an older branch (fix/pnpm-workspace-deps) addressing a similar peer dependency range issue that was never merged. This PR attempts to provide a minimal fix addressing the same underlying problem.
Checklist
Related Issues
#7591
#7253