fix: preserve lazy continuation lines in ordered lists (CommonMark)#7694
Open
fix: preserve lazy continuation lines in ordered lists (CommonMark)#7694
Conversation
…s\n\nAdd regression test; ensure non-indented continuation lines before a blank line remain part of the current list item. Fixes #7677.
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: d755a5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ordered-list Markdown tokenizer in @tiptap/extension-list to better match CommonMark behavior for “lazy continuation lines”, ensuring non-indented continuation lines remain inside the current ordered list item (until a blank line ends the item). It also adds Markdown-level regression tests to confirm parsing behavior (including marked line-break handling).
Changes:
- Adjust ordered-list item collection to include non-indented lazy continuation lines until a blank line or the next ordered list marker.
- Split list-item content into “paragraph” vs “block” parts to preserve inline continuation while still allowing nested block parsing.
- Add Markdown parsing regression tests and a changeset for the user-facing behavior change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/markdown/__tests__/ordered-list-lazy-continuation.spec.ts |
Adds regression tests covering lazy continuation lines, nested bullets, and blank-line termination. |
packages/extension-list/src/ordered-list/utils.ts |
Implements updated ordered-list item collection and content splitting to preserve lazy continuations. |
.changeset/ordered-list-lazy-continuation.md |
Adds a patch changeset documenting the ordered-list parsing fix. |
arnaugomez
approved these changes
Apr 7, 2026
arnaugomez
reviewed
Apr 7, 2026
Comment on lines
+27
to
+37
| function isBlockContentLine(line: string): boolean { | ||
| const trimmedLine = line.trimStart() | ||
|
|
||
| return ( | ||
| /^[-+*]\s+/.test(trimmedLine) || | ||
| /^\d+\.\s+/.test(trimmedLine) || | ||
| /^>\s?/.test(trimmedLine) || | ||
| /^```/.test(trimmedLine) || | ||
| /^~~~/.test(trimmedLine) | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
Could there be other block content elements that are not covered here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
Fix ordered-list markdown parsing so non-indented lazy continuation lines are kept as part of the current list item (CommonMark §5.3). This prevents continuation text from being dropped when
markedis configured withbreaks: trueand preserves nested list behavior.Implementation Approach
collectOrderedListItemsinpackages/extension-list/src/ordered-list/utils.tsto track whether a blank line has been seen and treat non-indented, non-list lines before a blank line as "lazy continuation" belonging to the current list item.contentLinesonOrderedListItem,splitItemContent(), andisBlockContentLine()helpers to separate paragraph (inline) lines from block-level lines.buildNestedStructure()to create the first paragraph usinglexer.inlineTokens()for the joined paragraph lines (sobreaks: trueproduceshardBreaktokens), and to parse later block content throughlexer.blockTokens()so nested lists / block nodes remain intact.packages/markdown/__tests__/ordered-list-lazy-continuation.spec.tsthat runs withmarkedOptions: { breaks: true }and verifies lazy continuation, nested bullet preservation, and blank-line termination..changeset/ordered-list-lazy-continuation.md.Testing Done
pnpm vitest run packages/markdown/__tests__/ordered-list-lazy-continuation.spec.ts— all tests passed.pnpm vitest run packages/markdown/__tests__/conversion.spec.ts— all tests passed.Verification Steps
git fetch && git checkout fix/ordered-list-lazy-continuationAdditional Notes
inlineTokens()to preservehardBreaknodes whenbreaks: true, while later block content is parsed viablockTokens()to retain nested lists and block nodes.Checklist
Related Issues
Fixes: #7677