Open
Conversation
🦋 Changeset detectedLatest commit: 8521ecb The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Twitch embed round-trip issue in @tiptap/extension-twitch where the original Twitch URL (video/clip/channel) could be lost when content is rendered to HTML and then parsed back into the editor.
Changes:
- Added a utility to reverse-parse Twitch embed URLs back into canonical node attributes (
src, plus relevant params). - Updated the Twitch node’s
addAttributes().parseHTMLhandling to restore canonicalsrc(and parse width/height/autoplay/muted/time from HTML). - Added a regression test to verify
srcis preserved across HTML round-trips, plus a changeset entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/extension-twitch/src/utils.ts | Adds getAttributesFromTwitchEmbedUrl to convert embed URLs back into canonical Twitch node attrs. |
| packages/extension-twitch/src/twitch.ts | Wires new parsing into parseHTML for node attributes so HTML re-import preserves canonical src. |
| packages/extension-twitch/tests/twitch.spec.ts | Adds round-trip regression test ensuring src survives HTML export/import. |
| .changeset/green-stingrays-shop.md | Adds a patch changeset describing the user-facing fix. |
…d add regressions
arnaugomez
approved these changes
Apr 7, 2026
| return { | ||
| src: { | ||
| default: null, | ||
| parseHTML: element => getParsedTwitchAttributes(element as HTMLElement)?.src, |
Contributor
There was a problem hiding this comment.
Is the casting (as operator) always valid here? Or could there be a situation where the element is not an HTML element?
Contributor
|
Should we do the same in the YouTube extension? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
Implementation Approach
packages/extension-twitch/src/utils.tsand wiredparseHTMLattribute parsing for the Twitch node inpackages/extension-twitch/src/twitch.ts.packages/extension-twitch/__tests__/twitch.spec.ts.Testing Done
Verification Steps
Additional Notes
.changeset/green-stingrays-shop.mdwith a short user-facing note. No public API changes were made.Checklist
pnpm lintif needed).Related Issues