Reapeat multi field page controller#656
Open
micolgiannelli2 wants to merge 3 commits into
Open
Conversation
This was referenced Jul 10, 2026
Closed
Collaborator
Author
|
note I removed all form changes this introduces the functionality of the new form component without making any form changes to the application, an example of a form implementaion is included in tests |
Dashue
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made a new component inspired for repeated field component that allows us to submit multiple fields at a time previously reviewed by @Dashue in linked prs, this version makes the page controller compatible with sections and with the summary page, and amends the payload by constructing an array containing objects for each repeated multifield
also includes better tests and clear errors for when the user doesn't correctly set parameters such as section key.
https://ukhsa.atlassian.net/browse/SBS-213
additional change:
-> landline number previously not included
Context
TODO..
Changes
Challenges encountered and work arounds
SummaryViewModelso that the summary transormations would be implemented I am not sure what the other possible solutions to this would beType of change
What is the type of change you are making?
PR title
PR titles should be prefixed with the type of change you are making, based on the README.md#versioning.
This is so that when performing a squash merge, the PR title is automatically used as the commit message.
Have you updated the PR title to match the type of change you are making?
Testing
Automated tests
Have you added automated tests?
Manual tests
Have you manually tested your changes?
Have you attached an example form JSON or snippet for the reviewer in this PR?
Steps to test
Documentation
Have you updated the documentation?
Discussion
Warning
Large or complex changes may require discussion with the maintainers before they can be merged. If it has not yet been discussed, it may delay the review process
Have you discussed this change with the maintainers?