Skip to content

Reapeat multi field page controller#656

Open
micolgiannelli2 wants to merge 3 commits into
v2from
micol/repeat-multi-field-clean
Open

Reapeat multi field page controller#656
micolgiannelli2 wants to merge 3 commits into
v2from
micol/repeat-multi-field-clean

Conversation

@micolgiannelli2

@micolgiannelli2 micolgiannelli2 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Made a new component inspired for repeated field component that allows us to submit multiple fields at a time previously reviewed by @Dashue in linked prs, this version makes the page controller compatible with sections and with the summary page, and amends the payload by constructing an array containing objects for each repeated multifield

also includes better tests and clear errors for when the user doesn't correctly set parameters such as section key.

https://ukhsa.atlassian.net/browse/SBS-213

additional change:
-> landline number previously not included

Context

TODO..

Changes

  • Change A
  • Change B

Challenges encountered and work arounds

  • The old version in our forms was using SummaryViewModel so that the summary transormations would be implemented I am not sure what the other possible solutions to this would be

Type of change

What is the type of change you are making?

  • Chore or documentation (non-breaking change that does not add functionality)
  • ADR (Architectural Decision Record, non-breaking change that documents or proposes a decision)
  • Refactor (non-breaking change that improves code quality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR title

PR titles should be prefixed with the type of change you are making, based on the README.md#versioning.
This is so that when performing a squash merge, the PR title is automatically used as the commit message.

Have you updated the PR title to match the type of change you are making?

  • Yes
  • No, I need help or guidance

Testing

Automated tests

Have you added automated tests?

  • Yes, unit or integration tests
  • Yes, end-to-end (cypress) tests
  • No, tests are not required for this change
  • No, I need help or guidance
  • No (explain why tests are not required or can't be added at this time)

Manual tests

Have you manually tested your changes?

  • Yes
  • No, manual tests are not required or sufficiently covered by automated tests

Have you attached an example form JSON or snippet for the reviewer in this PR?

  • Yes
  • No, any existing form can be used
  • No, it is not required or not applicable

Steps to test

  1. Step 1
  2. Step 2

Documentation

Have you updated the documentation?

  • Yes, I have updated ./docs for this change since additional explanation or steps to use/configure the feature is required
  • Yes, I have added or updated an ADR for this change since it is large, complex, or has significant architectural implications
  • Yes, I have added inline comments for hard-to-understand areas
  • No, I am not sure if documentation is required
  • No, documentation is not required for this change

Discussion

Warning

Large or complex changes may require discussion with the maintainers before they can be merged. If it has not yet been discussed, it may delay the review process

Have you discussed this change with the maintainers?

  • Yes, I have discussed this change with the maintainers on slack, email or via GitHub issues
  • Yes, this change is an ADR to help kick-off discussion
  • No, this change is small and does not require discussion
  • No, I am not sure if one is required

This was referenced Jul 10, 2026
@micolgiannelli2 micolgiannelli2 marked this pull request as ready for review July 10, 2026 11:33
@micolgiannelli2 micolgiannelli2 requested a review from a team as a code owner July 10, 2026 11:33
@micolgiannelli2

Copy link
Copy Markdown
Collaborator Author

note I removed all form changes this introduces the functionality of the new form component without making any form changes to the application, an example of a form implementaion is included in tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants