project: fix black + python#2316
Conversation
|
@lasers thx. I'd rather pin and fix for newer black versions than pin an older version please? |
OK on fixing for latest black. |
|
@lasers sorry I was not clear I meant to pin a "higher than" black version in the requirements to make it clear that we expect at least this version |
|
@ultrabug My fault anyway for assuming. Also, I believe I found a better solution that doesn't involve pinning newer black. Just adding The plan would be to revisit several EDIT: Need to know your choice now with this alternative solution now included. |
|
Sounds reasonable, thank you |
I missed one thing in dropping python 3.9. Sorry.
Black released a new version. I addressed this change early.
However, we all are running different black versions. There is a new change that could cause unwanted formatting issues repeatedly due to older black version (in editors auto formatting) and such. Because I addressed unnecessary parentheses early, the remaining new changes is just two files below.
And...
If you want me to fix them too (and drop pinned black), I can. Some editors will run older black on save and revert the formats... is which why I think it's okay to pin black for a while. Also, because of git pre-push hook too.