playerctl: apply button options selectively

[lasers]

This clears out the default buttons.

I initially don't know whenever to leave button_play_pause alone... or to let users configure that themselves. If we leave button_play_pause at default, then an user can run into same problem with a different button. It is more clean not to assign any default buttons.

And this checks for duplicate buttons too.

/cc notifying @jdholtz author on buttons

Closes #2324

[ultrabug]

Thanks @lasers ; that PR will break users using the module with default settings for ages.

Could we make it to actually respect the user's setting instead of resetting everything to None like this? I'm confused.

[lasers]

User requires button_stop = None in his/her config first in order to get a working button_next = 3.

User gave it a random number as a workaround/solution.

This can happen with any modules with default buttons. This one just has the largest button choices.

Do we suggest users to assign default buttons with something else first?

My approach for this module with that many button choices was that there are no default buttons anymore and users just assign what they want to use.

Happy to hear your suggestions/solutions.

[ultrabug]

I understand but I'm also wary of breaking something being used seamlessly by possibly a large number of users vs one having a specific case even if it's indeed not smooth for her/him.

In this case my favored approach would be :

• on the validation function step, check if user tried to use one of the default (1 or 3) button number by setting them on another button
• if so, set the previously set button to None
• else, keep the default

Does it make sense mate?

[lasers]

OK. I added a commit. I like the first one. It's more neutral in the long run. I think it also could lead to users having button_play = 1 or button_play_pause = 1 in their config and not needing button_stop = 3.

The second one contains your favored approach. Just more post_config_hook code. Everything seems to work fine on my side. Please review and if you like this, I'll squash em and update PR title+commit. 👍

P.S. This kind of button code validation could be applied to all modules with buttons in the eventual future, just not in modules themselves. It'll do for now.

[ultrabug]

I think the second and current one is my favored yes