sysdata: streamline metric collection#2349
Open
lasers wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
@anarcat for potential zfs testing |
Contributor
|
hey, i'm sorry but i can't test this as i don't run zfs on my desktop anymore and i don't even run py3status either. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
sysdata: drop legacyfirst #2348.(qol cleanup) OK. I wanted to do this for some time... to move them into functions and keep updating with returned dicts in the loop, but codex says it's better to mutate everything instead... that way we don't have any really short-lived dict initialization and stuff like that. OK, we'll mutate.
I made minor change to
arc_get_size... assuming that zfs, loaded on startup in /proc or not, will either stay there indefinitely or not. Users without zfs gets0... and no zfs regex is needed because the line looks very easy to parse.Moved lot of things to
post_config_hooktoo so we can stick with minimal functions including optional last onemax_used_percent.In short,
sysdatacan be 1-20% faster than before compared to master. It is a wash with all placeholders. The expensive one islm_sensorscall for{cpu_temp}which I did not touch... mainly because we had various issues/prs wanting to fix{cpu_temp}.(nolink to various cpu_temp issues/prs) https://github.com/ultrabug/py3status/pull/2029.Benchmark.