parse_config: improve config loading#2351
Open
lasers wants to merge 1 commit into
Open
Conversation
lasers
force-pushed
the
parse_config_fallback
branch
from
July 21, 2026 15:37
2b518cc to
b6a51a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts config loading
utf-8-sigfirst (rather thanutf-8) with fallback to commandfile.It looks like py3status switched from
utf-8tofile(with fallbackutf-8) sometimes in the past to better handle files. However, becausefileis now tried first, it introduced new issues such as...filea hard dependency.filedoesn't have--mime-encodingfilesubprocess callI'm suggesting that we try again with
utf-8-sigfirst, then fallback to commandfilerather than staying with the other way around. The final fallback is default locale (instead of explicitutf-8), but we triedutf-8-sigfirst anyway.Strategy Comparison.
Benchmark.