fix(build): correct goreleaser build flags - #86
Merged
Conversation
Replace invalid gcflags/asmflags with proper flags option. Go 1.25 assembler rejects -trimpath in asmflags. Signed-off-by: umatare5 <umatare5@gmail.com> AI-assisted-by: GitHub Copilot Coding Agent
Improve README layout by separating badge rows. Signed-off-by: umatare5 <umatare5@gmail.com> AI-assisted-by: GitHub Copilot Coding Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
gcflags/asmflagswith properflagsoption in.goreleaser.yml-trimpathinasmflagsDetails
Go 1.25 introduced stricter validation in the assembler, causing builds to fail when
-trimpathwas specified inasmflags. This PR consolidates build flags into theflagsoption to resolve the issue.Commits
b81f5abfix(build): correct goreleaser build flags4494946style(docs): add line break after badge row