Fix compatibility with PHPCSFixer 2.x - #41
Open
lolautruche wants to merge 1 commit into
Open
Conversation
Symfony upgrade fixer is currently locked with PHPCSFixer `1.10.*` which is problem, especially if one has PHPCSFixer 2.x already installed globally with Composer. This PR simply fixes it. To make it work, I also removed support for PHP 5.4 in `.travis.yml` as it won't work with Symfony 3 (required by PHPCSFixer 2.x). And it's completely obsolete anyway now ;-). I also removed `hhvm` since it's also abandoned
lolautruche
force-pushed
the
fix/phpCSFixer2
branch
from
October 26, 2017 08:43
9900932 to
1aa1075
Compare
umpirsky
requested changes
Oct 26, 2017
umpirsky
left a comment
umpirsky
left a comment
Owner
There was a problem hiding this comment.
This is nice, but the tests are failing.
I know PHP-CS-Fixer 2.0 is very different from 1.0, and not sure how complex it is to migrate. The tests are failing, and we should not only make tests green, but also test it with 2.0 on real codebase to make sure it does not break.
Thanks.
| - 5.5 | ||
| - 5.6 | ||
| - 7.0 | ||
| - 7.1 |
Contributor
Author
|
Hi @umpirsky In any case, this should go into a new major version (or |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony upgrade fixer is currently locked with PHPCSFixer
1.10.*which is problem, especially if one has PHPCSFixer 2.x already installed globally with Composer.This PR simply fixes it.
To make it work, I also removed support for PHP 5.4 in
.travis.ymlas it won't work with Symfony 3 (required by PHPCSFixer 2.x). And it's completely obsolete anyway now ;-).I also removed
hhvmsince it's also abandoned.