Fix possible unbound variable issue in skeleton#1973
Conversation
|
Thanks for PR. Can you provide a description how can I replicate the issue so I can test it on local machine? I'm particularly interested in testing btw you forget to fill the template questions ;-) Did you used AI to create this code? |
b1683d0 to
7f7c222
Compare
|
I separated the 2 issues, so this is now just a fix for the unbound self referencing variables. To reproduce this you can add sorry, I did not see any template questions. I just checked the other open PRs and also couldn't see any templates. so if you have questions please ask away :) I did use AI to review the code change (because I wanted it to doublecheck the default values) the extracted issue is a contract issue, I will issue a separate pr for it |
|
any chance this can get merged? it is very disruptive in my dev workflow if the login page with |
|
@tomdtp hey Tom, as a team of one, it is pretty hard to go through everything and do a proper testing. So right now, there is no estimate when I will have time to think what I will do with this PR. |
|
@lukasvinclav ok, I understand. thanks for the great work on unfold it is such an improvement over the default django admin! |
|
@tomdtp I hope I didn't let you down. The "problem" here is that I have no experience with the plugin which you are using so I have to get familiar with it. Anyway, if you find something else don't feel discouraged and just post the issue here. |
|
@lukasvinclav no, no worries, it is not a critical issue in the sense that something breaks on production. I am not affiliated with |
Fixes self-referential template issues that showed up with
django-fastdevenabled.Also the regular changelist now follows Django’s own
action_form/cl.show_admin_actionscontract again, while dataset views get an explicithas_action_formflag so they only show bulk-action UI when actions are actually available.