feat: Switch to new linters#202
Conversation
henrikwidlund
changed the title
zehnm
left a comment
zehnm
left a comment
There was a problem hiding this comment.
As we've been discussing on Discord, pylint is more and more an annoying distraction and not really helpful in finding actual issues.
Requiring two more tools for formatting and doc checking doesn't make it better...
What is the pyproject.toml exactly used for? Does it finally cover the configuration for all involved tools?
I'll take a deeper look this week, especially the integration in PyCharm where I've configured an auto-format on save action and multiple run configurations for the linters.
If we are going forward with changing the linters, the following files have to be updated as well:
- Update docs/code_guidelines.md
- Update PyCharm settings (.idea folder) and run configurations --> I can take over that part
|
The changes in this pr is meant to replace the other tools we had. So we'd go from four to two. Maybe we can even use only one of them. The project.toml is meant to let you define build, linting, metadata etc and not have that scattered all over. Short answer; hopefully? But it's python so... I can fix the other two files now, then you can evaluate the complete thing |
henrikwidlund
force-pushed
the
feat/new_linters
branch
from
3560c1a to
9619d83
Compare
henrikwidlund
changed the title
# Conflicts: # intg-denonavr/denon_remote.py # intg-denonavr/denon_select.py # intg-denonavr/sensor.py # intg-denonavr/simplecommand.py
henrikwidlund
force-pushed
the
feat/new_linters
branch
from
d15db3b to
6b9bc88
Compare
henrikwidlund
force-pushed
the
feat/new_linters
branch
from
6b9bc88 to
8324df6
Compare
# Conflicts: # intg-denonavr/denon_select.py
2 participants
This is not meant to be merged, it's only meant to show what we'd end up with to see if we want it at all and which pieces we'd like to keep.