Skip to content

feat: 315764 Add push action when RDP is created#397

Open
roma-valor wants to merge 5 commits into
developfrom
feature/add-optional-push-to-create-rdp
Open

feat: 315764 Add push action when RDP is created#397
roma-valor wants to merge 5 commits into
developfrom
feature/add-optional-push-to-create-rdp

Conversation

@roma-valor

@roma-valor roma-valor commented May 28, 2026

Copy link
Copy Markdown
Contributor

Legal Boilerplate

AB#315764

When you run Create and Push, the action opens a configuration page with a form.
Currently, the form contains a single field: error threshold percentage required to allow the push.
This threshold defines the maximum acceptable error rate before the push is blocked. For example, if there are 300 records and 10 errors (tickets), the push is allowed because the error rate is below the configured threshold of 90% (i.e., only up to 30 errors would be acceptable).
If the number of errors exceeds the threshold, the push will not proceed.

@roma-valor
roma-valor force-pushed the feature/add-optional-push-to-create-rdp branch from d05ce6e to 85f4ee4 Compare May 28, 2026 12:31
@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.21429% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.11%. Comparing base (3f42d59) to head (8078cf4).

Files with missing lines Patch % Lines
...untry_workspace/contrib/hope/push/orchestration.py 98.13% 1 Missing and 1 partial ⚠️
...try_workspace/workspaces/admin/cleaners/actions.py 96.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #397      +/-   ##
===========================================
+ Coverage    97.05%   97.11%   +0.06%     
===========================================
  Files          240      241       +1     
  Lines        10383    10587     +204     
  Branches      1175     1200      +25     
===========================================
+ Hits         10077    10282     +205     
+ Misses         142      141       -1     
  Partials       164      164              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roma-valor
roma-valor marked this pull request as ready for review May 28, 2026 12:56
@roma-valor
roma-valor marked this pull request as draft June 1, 2026 14:52
@roma-valor
roma-valor force-pushed the feature/add-optional-push-to-create-rdp branch 6 times, most recently from ac0cb32 to 867c689 Compare June 29, 2026 08:44
@roma-valor
roma-valor marked this pull request as ready for review June 29, 2026 09:06
@roma-valor
roma-valor requested review from a team and saxix as code owners June 29, 2026 09:06
@roma-valor
roma-valor force-pushed the feature/add-optional-push-to-create-rdp branch 2 times, most recently from 3dfec25 to 6c623f3 Compare July 14, 2026 09:09
Comment thread src/country_workspace/contrib/hope/push/orchestration.py Outdated
Comment thread src/country_workspace/contrib/hope/push/orchestration.py Outdated
Comment thread src/country_workspace/contrib/hope/push/orchestration.py Outdated
@roma-valor
roma-valor force-pushed the feature/add-optional-push-to-create-rdp branch from 6c623f3 to b09f956 Compare July 15, 2026 07:18
@roma-valor
roma-valor requested a review from saxix July 15, 2026 07:39
Comment thread src/country_workspace/models/rdp.py Outdated
Comment thread src/country_workspace/contrib/hope/push/orchestration.py Outdated
Comment thread src/country_workspace/contrib/hope/push/orchestration.py Outdated
Comment thread src/country_workspace/contrib/hope/push/orchestration.py Outdated
Comment thread tests/contrib/hope/test_dedup_callback_view.py Outdated
Comment thread src/country_workspace/contrib/hope/push/orchestration.py Outdated
Comment thread src/country_workspace/workspaces/admin/cleaners/actions.py Outdated
@roma-valor
roma-valor force-pushed the feature/add-optional-push-to-create-rdp branch from ab38bbd to 34eac71 Compare July 21, 2026 07:51
Comment thread src/country_workspace/contrib/hope/push/orchestration.py Outdated
@roma-valor
roma-valor force-pushed the feature/add-optional-push-to-create-rdp branch from 34eac71 to 641cab1 Compare July 22, 2026 15:46
@roma-valor
roma-valor force-pushed the feature/add-optional-push-to-create-rdp branch from 641cab1 to 8078cf4 Compare July 23, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants