ICU-23297 Do not allow lookupMatcher to remap UnicodeSet syntax characters#3806
Merged
eggrobin merged 1 commit intounicode-org:mainfrom Dec 19, 2025
Merged
Conversation
richgillam
approved these changes
Dec 18, 2025
Contributor
richgillam
left a comment
richgillam
left a comment
There was a problem hiding this comment.
Didn't review this too deeply, but I think I understand what you're doing here and it seems to make sense.
eggrobin
force-pushed
the
no-remapping-syntax
branch
from
6021c3d to
26f66bb
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eventually we want to get rid of that mechanism entirely, but let us start by removing the biggest hacks it requires in the parser.
Checklist