Skip to content

ICU-23334 Fix null-deref and stale UErrorCode in break_iterator_fuzzer #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OwenSanzas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-23334 Fix null-deref and stale UErrorCode in break_iterator_fuzzer #3887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions icu4c/source/test/fuzzer/break_iterator_fuzzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
std::memcpy(fuzzbuff.get(), data, unistr_size * 2);

UText* fuzzstr = utext_openUChars(nullptr, fuzzbuff.get(), unistr_size, &status);
if (U_FAILURE(status) || fuzzstr == nullptr) {
return 0;
}

const icu::Locale& locale = GetRandomLocale(rnd16);

Expand All @@ -54,6 +57,11 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
break;
}

if (bi == nullptr || U_FAILURE(status)) {
utext_close(fuzzstr);
return 0;
}

bi->setText(fuzzstr, status);

if (U_FAILURE(status)) {
Expand All @@ -65,6 +73,9 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {

utext_close(fuzzstr);

// Reset status before second round of BreakIterator creation.
status = U_ZERO_ERROR;

std::string str(reinterpret_cast<const char*>(data), size);
icu::Locale locale2(str.c_str()); // ensure null-termination by c_str()
switch (rnd8 % 5) {
Expand Down