Skip to content

chore: prune PNPM dependency FOD#5224

Merged
ehegnes merged 7 commits into
mainfrom
pnpm-fod-fixes
Oct 9, 2025
Merged

chore: prune PNPM dependency FOD#5224
ehegnes merged 7 commits into
mainfrom
pnpm-fod-fixes

Conversation

@ehegnes

@ehegnes ehegnes commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

This PR overhauls PNPM integration with Nix in the interests of safety and developer experience. The result is fewer changes to per-project pnpm.fetchDeps fixed-output derivations in instances a dependency change in one project should not impact the dependencies of any unrelated project. This succeeds with the exception of instances where optional peer dependencies may be satisfied by workspace projects. This may be related to pnpm/pnpm#10046 or pnpm/pnpm#9288.

  • Pin pnpm and nodejs within Nix such that versions are shared across the dev shell and buildPnpmPackage.
  • Prefer nodejs-slim* package to remove npm.
  • Remove project-specific .npmrc files such that a root pnpm-workspace.yaml consolidates dependency resolution configuration.
  • Remove scripts/docs.mjs in favor of Nix output for TSDoc generated Markdown.
  • Remove a substantial set of root workspace dependencies from root package.json.
  • Enhance PNPM integration:
    • Enforce strict peer dependencies and removal of peer auto-install to fortify reproducibility.
    • Enforce minimum dependency release age to fortify supply-chain attack protection.
    • Use PNPM catalogs to easily specify consistent versions of common dependencies.
    • Declare a peer catalog to relax version range when specifying peer dependencies.
  • Cleanup unused/deprecated dependencies in app:
    • Remove @aptos-labs/* which improves bundle output size by ~50%.
    • Remove @unionlabs/client which is deprecated in favor of @unionlabs/sdk and family.
  • Bump various dependencies, notably:
    • @types/nodejs@^24 to align with the pinned Node.js version for shell & build.

@vercel

vercel Bot commented Oct 7, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
site Skipped Skipped Oct 8, 2025 9:17pm

@github-actions

github-actions Bot commented Oct 7, 2025

Copy link
Copy Markdown

Ceremony 🤌

✨ Deployment complete! Take a peek over at https://eb6e4621.ceremony-e8z.pages.dev
✨ Deployment alias URL: https://head.ceremony-e8z.pages.dev


@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown

App 2 🤌

✨ Deployment complete! Take a peek over at https://89cd63f3.app2-9yo.pages.dev
✨ Deployment alias URL: https://head.app2-9yo.pages.dev


Signed-off-by: Eric Hegnes <eric@hegnes.com>
Signed-off-by: Eric Hegnes <eric@hegnes.com>
Signed-off-by: Eric Hegnes <eric@hegnes.com>
@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown

zkgm.dev 🦀

✨ Deployment complete! Take a peek over at https://b9f3a186.zkgm-dev.pages.dev
✨ Deployment alias URL: https://head.zkgm-dev.pages.dev


Signed-off-by: Eric Hegnes <eric@hegnes.com>
@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown

Docs 🤌

✨ Deployment complete! Take a peek over at https://a3b105e3.docs-ajn.pages.dev
✨ Deployment alias URL: https://head.docs-ajn.pages.dev


Signed-off-by: Eric Hegnes <eric@hegnes.com>
Signed-off-by: Eric Hegnes <eric@hegnes.com>
… package derivation

Signed-off-by: Eric Hegnes <eric@hegnes.com>
@ehegnes ehegnes temporarily deployed to zkgm-dev-preview October 8, 2025 21:17 — with GitHub Actions Inactive
@ehegnes ehegnes temporarily deployed to ceremony-preview October 8, 2025 21:17 — with GitHub Actions Inactive
@ehegnes ehegnes marked this pull request as ready for review October 8, 2025 21:19
Comment thread docs/astro.config.ts
Comment thread tools/typescript/buildPnpmPackage.nix

@PoisonPhang PoisonPhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets make sure we are tracking TODOs

Comment thread app2/src/routes/explorer/stakes/[packet_hash]/+page.svelte
Comment thread app2/src/routes/explorer/stakes/[packet_hash]/+page.svelte
@ehegnes ehegnes merged commit 35dbafc into main Oct 9, 2025
155 of 156 checks passed
@ehegnes ehegnes deleted the pnpm-fod-fixes branch October 9, 2025 18:12
@unionlabs unionlabs deleted a comment from apomonzer4-ship-it Dec 1, 2025
@unionlabs unionlabs locked as spam and limited conversation to collaborators Dec 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants