Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts ScrollViewer’s deferred intermediate scrolling updates to be scheduled at normal dispatcher priority (instead of idle) to improve update reliability during sustained scrolling.
Changes:
- Switch deferred update scheduling from
Dispatcher.RunIdleAsync(...)toDispatcher.RunAsync(CoreDispatcherPriority.Normal, ...)inScrollViewer.RequestUpdate().
Comments suppressed due to low confidence (1)
src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs:1333
- In RequestUpdate(),
_hasPendingUpdateis set totrueonly after scheduling the dispatcher callback. If the dispatcher implementation ever executes the callback synchronously (e.g., via a customCoreDispatcher.DispatchOverridein some hosts/tests), the callback can observe_hasPendingUpdate == false, skipUpdate(...), and then_hasPendingUpdatebecomestruewith no further callback queued (updates can get stuck). Set_hasPendingUpdate = truebefore callingDispatcher.RunAsync(...)to make the ordering robust.
_ = Dispatcher.RunAsync(CoreDispatcherPriority.Normal, () =>
{
if (_hasPendingUpdate)
{
Update(isIntermediate: true);
}
});
_hasPendingUpdate = true;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22921/wasm-skia-net9/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes #
PR Type:
What is the current behavior? 🤔
Improve scrolling reliability before #22873
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️