test(focus-scope): shadow root issue patched example#2353
Draft
ldelhommeau wants to merge 2 commits intounovue:v2from
Draft
test(focus-scope): shadow root issue patched example#2353ldelhommeau wants to merge 2 commits intounovue:v2from
ldelhommeau wants to merge 2 commits intounovue:v2from
Conversation
commit: |
0a4e712 to
e351e2d
Compare
8 tasks
b5fe378 to
38dfd4e
Compare
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
cf9f78e to
3404617
Compare
3404617 to
305b528
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example branch about the focus isse mentionned in #1667 :
The reproduction branch is this one: #2331
The fix is here: #2352
What has been patched
See the patch here: #2352
How to reproduce
pnpm story:devExpected behaviour
The focus should not be lost.
Here is an example of how it should behave.
Screen.Recording.2025-12-23.at.13.18.50.1.1.mp4