feat(dismissable-layer): add shadow root support#2358
Closed
ldelhommeau wants to merge 5 commits intounovue:v2from
Closed
feat(dismissable-layer): add shadow root support#2358ldelhommeau wants to merge 5 commits intounovue:v2from
ldelhommeau wants to merge 5 commits intounovue:v2from
Conversation
ldelhommeau
force-pushed
the
feat/dimissible-layer-shadow-root
branch
2 times, most recently
from
88ee42d to
f41534d
Compare
ldelhommeau
commented
Jan 2, 2026
| /> | ||
| </ComboboxTrigger> | ||
| </ComboboxAnchor> | ||
| <ComboboxPortal :to="portalTarget"> |
Contributor
Author
There was a problem hiding this comment.
Combobox popper element will be teleported to the shadow root given div. (in props)
ldelhommeau
commented
Jan 2, 2026
| > | ||
| Main Trigger | ||
| </DialogTrigger> | ||
| <DialogPortal :to="portalTarget"> |
Contributor
Author
There was a problem hiding this comment.
Dialog dismissable layer will be teleported into shadow root (from props given div)
ldelhommeau
commented
Jan 2, 2026
| /> | ||
| </DropdownMenuTrigger> | ||
|
|
||
| <DropdownMenuPortal :to="portalTarget"> |
Contributor
Author
There was a problem hiding this comment.
Same here, using the portal to teleport the dropdown popper element into shadow root.
ldelhommeau
commented
Jan 2, 2026
| > | ||
| <Icon icon="radix-icons:gear" /> | ||
| </PopoverTrigger> | ||
| <PopoverPortal :to="portalTarget"> |
Contributor
Author
There was a problem hiding this comment.
Same here to teleport Popover popper element into shadow root
ldelhommeau
commented
Jan 2, 2026
Contributor
Author
There was a problem hiding this comment.
To create a simple Shadow Root container and mount DialogShadowRoot inside
commit: |
ldelhommeau
force-pushed
the
feat/dimissible-layer-shadow-root
branch
from
7359ea7 to
1641e82
Compare
ldelhommeau
changed the title
Contributor
Author
|
Closing this PR in favor of this new one: Which has fewer changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.