You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I had a problem trying to dismiss the drawer with scrollable content on iOS, investigating a bit I notice that vaul's repo have a use-prevent-scroll.ts hook that fix that, so I ported to vaul-vue.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Just wanted to note that this fix would be really helpful for users — the current scroll issue affects real usage, especially on mobile. Appreciate the work done here, and hoping this can be merged when maintainers have time.
It actually brokes when used with snap points, like [0.5, 0.7] and you scroll down. It blinks to top anchor and then swipes down.
upd: maybe this is not the issue with PR changes, but ported library itself. It doesn't seem to appear in 0.4.1 w/o this PR
It actually brokes when used with snap points, like [0.5, 0.7] and you scroll down. It blinks to top anchor and then swipes down. upd: maybe this is not the issue with PR changes, but ported library itself. It doesn't seem to appear in 0.4.1 w/o this PR
seems like we should fork it and make fixes by ourselves with npm publishing 😄
I tried fixing scrolling with snap points to no avail. I Started from the fork in this pull request but it was still broken. Even without snap points it was broken. Please let me know if you make it work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a problem trying to dismiss the drawer with scrollable content on iOS, investigating a bit I notice that vaul's repo have a
use-prevent-scroll.tshook that fix that, so I ported to vaul-vue.