Fix missing ParameterModule export in GPT-OSS compiler path by danielhanchen · Pull Request #519 · unslothai/unsloth-zoo

danielhanchen · 2026-02-25T17:10:00Z

Summary

Fixes GPT-OSS compiled-cache failures where generated modules can reference ParameterModule but the symbol is not available from transformers.models.gpt_oss.modeling_gpt_oss.

Root cause

ParameterModule is defined in unsloth_zoo.temporary_patches.gpt_oss, but compiler-generated code expects symbols to be resolvable from the GPT-OSS modeling namespace.

Changes

Added patch_gpt_oss_compiler_exports() in unsloth_zoo/temporary_patches/gpt_oss.py.
Exported compiler-required symbols into transformers.models.gpt_oss.modeling_gpt_oss:
- ParameterModule
- swiglu_torch_forward
- dtype_from_config
- transformers_version
- Version
Registered the hook via TEMPORARY_PATCHES.append(patch_gpt_oss_compiler_exports).
Normalized GPT-OSS guard matching with UNSLOTH_MODEL_NAME.replace("-", "_") usage across key 4-bit/load guards.
Cleaned compiler export patch flow in exception path and removed redundant pass.
Updated compiler decorator stripping to handle:
- @use_kernel_forward_from_hub(...)
- @auto_docstring
  This removes noisy unknown-decorator warnings in GPT-OSS compile paths.

Validation

Run dirs:

logs/pr519_verify_20260226_031808/test_gpt_oss_compiler_export.log
logs/pr519_verify_20260226_031808/test_gpt_oss_compiler_export_after_autodoc_reinstall.log

Results:

GPT-OSS compiler export smoke test: PASS
@use_kernel_forward_from_hub unknown decorator warning: removed
@auto_docstring unknown decorator warning: removed

Notes

This change is scoped to symbol export and compile-time compatibility. It does not modify model math.

gemini-code-assist · 2026-02-25T17:10:13Z

Summary of Changes

Hello @danielhanchen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves GPT-OSS compiled-cache failures by ensuring that critical symbols, such as ParameterModule, are properly exposed within the transformers.models.gpt_oss.modeling_gpt_oss namespace. This change prevents runtime errors that occur when compiled GPT-OSS modules attempt to resolve these previously missing symbols, thereby improving the stability and functionality of compiled GPT-OSS models.

Highlights

New Patch Function: Added patch_gpt_oss_compiler_exports() to unsloth_zoo/temporary_patches/gpt_oss.py.
Symbol Export: Exported ParameterModule, swiglu_torch_forward, dtype_from_config, transformers_version, and Version into transformers.models.gpt_oss.modeling_gpt_oss for compiler resolution.
Patch Registration: Registered the new patch function by appending it to TEMPORARY_PATCHES.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

unsloth_zoo/temporary_patches/gpt_oss.py
- Added a new function patch_gpt_oss_compiler_exports to conditionally import transformers.models.gpt_oss.modeling_gpt_oss.
- Implemented the export of ParameterModule, swiglu_torch_forward, dtype_from_config, transformers_version, and Version into the modeling_gpt_oss module.
- Registered the patch_gpt_oss_compiler_exports function to the TEMPORARY_PATCHES list.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly addresses a compiler failure for GPT-OSS models by exporting necessary symbols like ParameterModule into the transformers.models.gpt_oss.modeling_gpt_oss namespace. The implementation is straightforward and adds a new patch function patch_gpt_oss_compiler_exports to handle this. My only feedback is a minor code cleanup suggestion to improve readability.

gemini-code-assist · 2026-02-25T17:10:43Z

unsloth_zoo/temporary_patches/gpt_oss.py

+    m.dtype_from_config = dtype_from_config
+    m.transformers_version = transformers_version
+    m.Version = Version
+pass


The pass statement here is redundant and can be removed. Python functions with a non-empty body do not require an explicit pass at the end.

unsloth_zoo/temporary_patches/gpt_oss.py

Datta0 · 2026-02-25T17:22:04Z

unsloth_zoo/temporary_patches/gpt_oss.py



+def patch_gpt_oss_compiler_exports():
+    model_name = os.environ.get("UNSLOTH_MODEL_NAME", "").replace("-", "_")


Ideally, if our temporary_patches creates and references a class, compiler.py should automatically handle copying it over. But for now this is fine.

Datta0 · 2026-02-25T17:28:48Z

unsloth_zoo/temporary_patches/gpt_oss.py

+
+    # Export helpers so compiler generated GPT-OSS modules can resolve symbols.
+    m = transformers.models.gpt_oss.modeling_gpt_oss
+    m.ParameterModule = ParameterModule


My only worry here is that this would leave from unsloth_zoo.temporary_patches.gpt_oss import ParameterModule in the unsloth_compiled_module_gpt_oss.py. Can you please verify where the import resolves to and it doesnot create a dependency cycle?

danielhanchen · 2026-02-26T03:19:45Z

Addressed review comments on #519 and verified import resolution:

Added guard normalization for hyphenated GPT-OSS names across key 4-bit/load guards.
Cleaned patch_gpt_oss_compiler_exports exception path and removed redundant trailing pass.
Updated compiler rewrite to strip @use_kernel_forward_from_hub(...) and @auto_docstring decorators so these no longer emit unknown-decorator warnings in GPT-OSS compile path.

Datta concern check (dependency cycle):

Ran temp/test_gpt_oss_compiler_export.py after reinstalling from source on this branch.
Compiled module generated at unsloth_compiled_cache/unsloth_compiled_module_gpt_oss.py and import path resolved successfully.
No dependency cycle hit; test passes.

Latest verification logs:

logs/pr519_verify_20260226_031808/test_gpt_oss_compiler_export_after_autodoc_reinstall.log

Fix GPT-OSS compiler exports for ParameterModule

2524b1b

gemini-code-assist bot reviewed Feb 25, 2026

View reviewed changes

github-code-quality bot found potential problems Feb 25, 2026

View reviewed changes

unsloth_zoo/temporary_patches/gpt_oss.py Fixed Show fixed Hide fixed

unsloth_zoo/temporary_patches/gpt_oss.py Fixed Show fixed Hide fixed

Normalize GPT-OSS model-name guard for compiler exports

5776d3c

github-code-quality bot found potential problems Feb 25, 2026

View reviewed changes

unsloth_zoo/temporary_patches/gpt_oss.py Fixed Show fixed Hide fixed

Datta0 approved these changes Feb 25, 2026

View reviewed changes

danielhanchen added 4 commits February 26, 2026 03:16

Normalize GPT-OSS model name guards for hyphenated names

d164b79

Strip use_kernel_forward_from_hub decorators during class rewrite

2e1b178

Clean compiler export patch flow and drop redundant pass

4dd1ed6

Strip @auto_docstring decorators during class rewrite

a870ecc

Handle GPT-OSS 5.2 mask kwargs and strip kernelized decorators

bf5e103

This was referenced Feb 26, 2026

Guard GPT-OSS allocator warmup on low-memory 4-bit loads #521

Open

Fix gptoss 4bit #524

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing ParameterModule export in GPT-OSS compiler path#519

Fix missing ParameterModule export in GPT-OSS compiler path#519
danielhanchen wants to merge 7 commits intomainfrom
fix/gpt-oss-parametermodule-compiler-export

danielhanchen commented Feb 25, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 25, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Datta0 Feb 25, 2026

Uh oh!

Datta0 Feb 25, 2026

Uh oh!

danielhanchen commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		def patch_gpt_oss_compiler_exports():
		model_name = os.environ.get("UNSLOTH_MODEL_NAME", "").replace("-", "_")

Conversation

danielhanchen commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Changes

Validation

Notes

Uh oh!

gemini-code-assist bot commented Feb 25, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Datta0 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Datta0 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

danielhanchen commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

danielhanchen commented Feb 25, 2026 •

edited

Loading