Fix Windows setup access-denied on existing llama-server ACLs#4881
Draft
aiSynergy37 wants to merge 2 commits intounslothai:mainfrom
Draft
Fix Windows setup access-denied on existing llama-server ACLs#4881aiSynergy37 wants to merge 2 commits intounslothai:mainfrom
aiSynergy37 wants to merge 2 commits intounslothai:mainfrom
Conversation
Catch UnauthorizedAccessException for llama-server path probes, repair ACLs via icacls, and add static regression tests.\n\nFixes unslothai#4846
aiSynergy37
requested review from
danielhanchen and
rolandtannous
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnauthorizedAccessExceptionicacls) to grant current user modify and Users read/execute on~/.unsloth/llama.cpptests/studio/install/test_pr4562_bugfixes.pyWhy
On Windows, running
unsloth studio setupelevated can leavellama-server.exeinaccessible from non-elevated sessions, and rawTest-Pathprobes can abort setup withAccess is denied.Validation
pytest tests/studio/install/test_pr4562_bugfixes.py -k "setup_ps1" -vFixes #4846