docs: add RTL layout anti-patterns audit for i18n support - #100
Closed
esafwan wants to merge 6 commits into
Closed
Conversation
Documents the full implementation plan for: - i18n infrastructure in pos/src/i18n/ - Language resolution strategy - Component refactoring to use t() - AGENTS.MD documentation files for pos/, root, and URYMosaic/ https://claude.ai/code/session_01QhB9M6JhTa6gJRp1wfZZbv
- Add pos/src/i18n/ infrastructure: config, loader, resolve-language, t() - Add en.json and fr.json translation files with structured namespaces - Wire initI18n() into main.tsx before React render - Refactor Header, OrderPanel, POSOpeningDialog, CommentDialog, CustomerSelect, PaymentDialog, POS, and Orders to use t() - Create pos/AGENTS.MD: detailed POS frontend docs for AI agents - Create AGENTS.MD (root): Frappe backend structure and navigation guide - Create URYMosaic/AGENTS.MD: KOT display system docs for AI agents - Create CLAUDE.MD files pointing to AGENTS.MD in each location https://claude.ai/code/session_01QhB9M6JhTa6gJRp1wfZZbv
frappe.local.lang is already set from the user's ERPNext language preference. Wrapping item_name and course with _() causes Frappe to look up Translation DocType entries for the active language, so cashiers see translated item and course names without any frontend changes. https://claude.ai/code/session_01QhB9M6JhTa6gJRp1wfZZbv
Audit identifies 47 layout anti-patterns that break with dir=rtl: - 8 space-x-* utilities (should use gap-*) - 14 directional margins ml-*/mr-* (should use ms-*/me-* or gap) - 9 absolute positioning with left/right - 6 directional padding issues - 4 directional borders Critical case flagged: - Header.tsx line 141: User menu button uses space-x-2 Pattern: div(avatar) + span(username) + svg(arrow) This creates ml-* margins that don't flip in RTL Fix: Replace space-x-* with gap-* which auto-mirrors in RTL
…layout-for-i18n-rtl-support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit identifies 47 layout anti-patterns that break with dir=rtl:
Critical case flagged:
Fix: Replace space-x-* with gap-* which auto-mirrors in RTL