Skip to content

Created Intersection Validation Plugin Shell#866

Open
radishco wants to merge 4 commits intodevelopfrom
vh_1534_intersection_validation_shell
Open

Created Intersection Validation Plugin Shell#866
radishco wants to merge 4 commits intodevelopfrom
vh_1534_intersection_validation_shell

Conversation

@radishco
Copy link
Copy Markdown
Contributor

@radishco radishco commented Apr 10, 2026

PR Details

Description

Created the shell for the Intersection Validation Plugin, including .h, .c files, CMakeLists, manifest.json and READme.

Related GitHub Issue

Related Jira Key

VH-1534

Motivation and Context

New plugin for CTI 4501 message validation on the edge.

How Has This Been Tested?

Local deployment testing

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown
Contributor

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Please add this new plugin to the sonar.properties file. Please also add empty test CPP

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)
0.0% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

TelematicBridgePlugin.sonar.tests=test
MUSTSensorDriverPlugin.sonar.tests=test
FLIRCameraDriverPlugin.sonar.tests=test
#IntersectionValidationPlugin.sonar.tests=test
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO not comment this out. As long as there exists, test cases this should work


## Introduction

The Intersection Validation Plugin is responsible for validating MAP, SPaT and TIM messages received from RSUs prior to sending these messages to Connected Intersections Message Monitoring Systems (CIMMS).
Copy link
Copy Markdown
Contributor

@paulbourelly999 paulbourelly999 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we will send this data to CIMMS/CV Manager, for modularity sake, this plugin will only handle message validation. Specifically CTI 4501 message validation. Please update the description to remove references to CIMMS and add a reference to CTI 4501

Copy link
Copy Markdown
Contributor

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address some of the sonar scan code smells. Specifically the ones not related to TODO or const method signatures. Like the ones suggesting we remove using directive from header files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants