Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
|
Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
|
Deployment #731 deployment failed
Deployed on Manufact.com |
Comment on lines
+43
to
+46
| return { | ||
| dir, | ||
| contents: JSON.stringify({ name: packageJson.name, private: true }), | ||
| }; |
Contributor
There was a problem hiding this comment.
printf treats its first argument as a format string, so any % character in contents would be misinterpreted as a format specifier. While npm package names cannot contain %, using printf '%s' with the content as a separate argument is the defensive idiom that avoids the risk entirely.
Prompt To Fix With AI
This is a comment left during a code review.
Path: trigger.config.ts
Line: 43-46
Comment:
`printf` treats its first argument as a format string, so any `%` character in `contents` would be misinterpreted as a format specifier. While npm package names cannot contain `%`, using `printf '%s'` with the content as a separate argument is the defensive idiom that avoids the risk entirely.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
License prices now always use the license plan’s Stripe Product (not the parent), removing ambiguity in back-sync and making attach/update customizations consistent.
planLicenseToCustomStripeInitProduct,planLicenseToStripeInitProduct).package.jsonfiles during image build to satisfy Bun, remove copying of workspace manifests, and replaceadditionalFileswith a custom image step using@trigger.devinstructions.Written for commit d81a6ab. Summary will update on new commits.
Greptile Summary
This PR changes the Stripe Product ownership model for customized license prices: previously, customized prices were created under the parent product's Stripe Product; they now live under the license product's own Stripe Product. The
planLicenseToCustomStripeInitProduct/planLicenseToStripeInitProducthelpers drop theparentProductparameter entirely, andtrigger.config.tsreplacesadditionalFilescopies of realpackage.jsons with runtime-generated stubs.licenseStripeResourceUtils.ts— removedparentProductcoupling; customized prices now reference the license's own Stripe Product, which also removes the guard that silently suppressed custom prices when the parent had noprocessor.id.initStripeResourcesForProducts.ts/initStripeResourcesForBillingPlan— call sites updated:parentProductlookup andcusProductToProductwrappers removed from license-transition handling, simplifying the billing plan initialisation path.trigger.config.ts— workspacepackage.jsonstubs are now generated withprintfin a single DockerfileRUNlayer rather than individuallyCOPY-ing real manifests, reducing image layer count and avoiding stale dependency lists in the deploy image.Confidence Score: 4/5
The core billing change is intentional and well-tested; the trigger.config.ts refactor is straightforward with only a minor printf format-string edge case unreachable with valid npm package names.
The billing ownership model change is structural but thoroughly covered by updated integration tests, and the removed null-guard was itself a correctness concern. No logic paths are left untested.
trigger.config.ts — the printf stub-generation command embeds JSON content directly as a format string.
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Merge branch 'main' into dev" | Re-trigger Greptile