Skip to content

fix(licenses): inherit assignment activity from parents - #2353

Merged
charlietlamb merged 1 commit into
devfrom
charlie/license-parent-activity
Jul 22, 2026
Merged

fix(licenses): inherit assignment activity from parents#2353
charlietlamb merged 1 commit into
devfrom
charlie/license-parent-activity

Conversation

@charlietlamb

@charlietlamb charlietlamb commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • treat a license assignment as active only when its stable pool link has an active parent
  • preserve assignments carried across matched license successors
  • cover dropped and matched pool transitions end to end

Validation

  • bunx tsgo --build --noEmit
  • Biome on changed files
  • dropped pool regression: pass
  • matched successor control: pass
  • ambiguous mapping guard: pass
  • unused pool transition: pass

@vercel
vercel Bot temporarily deployed to Preview – autumn-vite July 22, 2026 12:33 Inactive
@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
checkout Ignored Ignored Jul 22, 2026 12:40pm
landing-page Ignored Ignored Jul 22, 2026 12:40pm

Request Review

@capy-ai

capy-ai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Confidence score: 5/5

  • Safe to merge after the addressed issues were fixed.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread server/src/internal/licenses/repos/licenseAssignmentRepo.ts
@charlietlamb
charlietlamb force-pushed the charlie/license-parent-activity branch from 7fcb25d to a2912d4 Compare July 22, 2026 12:40
@vercel
vercel Bot temporarily deployed to Preview – autumn-vite July 22, 2026 12:40 Inactive
@charlietlamb
charlietlamb merged commit f25a7dd into dev Jul 22, 2026
16 checks passed
@charlietlamb
charlietlamb deleted the charlie/license-parent-activity branch July 22, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant