Allow negative auto-topup thresholds - #2354
Merged
Merged
Conversation
Contributor
|
Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bun test shared/models/cusModels/billingControls/customerBillingControls.test.tsbunx tsgo --build --noEmit(server)bunx biome checkon changed filesSummary by cubic
Allow negative auto-topup thresholds across the API and UI. The shared
AutoTopupSchemanow accepts negative threshold values, UI checks inBillingAutoTopupSheetand the plan billing form no longer block negatives, and a regression test verifies the behavior.Written for commit 4987187. Summary will update on new commits.
Greptile Summary
This PR allows auto-top-up thresholds below zero. The main changes are:
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(billing): allow negative auto-topup ..." | Re-trigger Greptile
Context used: