feat(catalog-v2): version-anchored license links - #3163
Draft
johnyeocx wants to merge 2 commits into
Draft
Conversation
…child sibling Parent plan_licenses stay on the child version they point at. Child all_versions follow applies each parent's overlay from that sibling's diff, and the dashboard can select those versions (including by slug). Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Lock the four-direct per-version path so adding a child feature keeps anchors, omits sibling_versions, restates overlays, and drafts a collapsed migration. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan_licenserows stay on the child version they point at. Child mint/promote no longer auto-repoints; follow ispropagate.license_parents, and an explicitlicenses[].version_slugis the only declared move.all_versionsfollow applies each parent version from the child sibling it is actually anchored to (content only — no relink).version_slugcan pin a specific parent version.Test plan
bun t server/tests/integration/catalog-v2/plans/licenses/mix/all-versions-parent-version-anchors.test.ts --headlessbun t server/tests/integration/catalog-v2/plans/licenses/declared/declared-version-anchor.test.ts --headlessbun t server/tests/integration/catalog-v2/plans/licenses/lifecycle/anchored-version-remove.test.ts --headlessMade with Cursor
Summary by cubic
Parent license links now stay anchored to the child version they point at instead of re-pointing to the newest child version when the child mints a new version or promotes. A
version_sluginlicenses[]is the only declared move; omitting it keeps the existing link, and new links default to the child's active row.Behavior changes
all_versionsfollow applies each parent version from the child sibling it is anchored to, leaving anchors in place.Callers that relied on links automatically following a child mint or promote must now pass
version_slug(or use propagate) to move them.Written for commit e637862. Summary will update on new commits.