test(billing): assert accruedOverage in carry-over shape expectations - #3193
Merged
Conversation
cusProductToExistingUsages now reports accruedOverage alongside usage, so the four toEqual shape assertions in the credit-rate carry-over suite were failing on the added key. All four cases have a positive source balance, so the expected value is 0. Fixes the Unit Tests job on the dev -> main release PR.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![capy-ai[bot]](https://avatars.githubusercontent.com/in/1915919?s=60&v=4){kind=small}
|
Note Production impact unlikely. Documentation, test, or CI-only change; nothing that runs in production is affected. Polylane analysed |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the Unit Tests job on the
dev -> mainrelease PR (#3189).cusProductToExistingUsagesnow reportsaccruedOveragealongsideusage. Four assertions incredit-rate-card-attribution-carry.test.tscompare the wholeExistingUsagesentry withtoEqual, so the added key made them fail on shape rather than on value.All four cases have a positive source balance — nothing had exceeded its allowance — so the expected value is
0. The rest of eachtoEqualis untouched, so the assertions keep their original coverage.A fifth site in the same file builds an
ExistingUsagesinput by hand and was already passing; deliberately left alone.Full unit suite locally: 3904 passed, 0 failed.
Summary by cubic
Adds
accruedOverageto four carry-over shape assertions so the unit tests pass again on thedev -> mainrelease PR.cusProductToExistingUsagesnow reportsaccruedOveragealongsideusage, which made thesetoEqualassertions fail on shape. All four cases have a positive source balance, so the expected value is0.Written for commit 7c954f5. Summary will update on new commits.