feat(balances): price tracks by credit dimensions - #3220
Draft
charlietlamb wants to merge 1 commit into
Draft
Conversation
getCreditSchemaItem is the one place dimensions enter: a row with rules is projected through resolveCreditDimensionRate into an ordinary flat or graduated item (most specific match sets the rate, every matching multiplier scales it, no match keeps the row's rate), so the cost math, rate cards, Lua and SQL stay unchanged. The winning dimension names the attribution key. Event properties are threaded from the deduction options through computeCreditCosts and the creditSystemUtils entry points, the check conversion, and finalize — which previously dropped the receipt's properties. Dimensioned rows join the fail-closed set and report no single rate to analytics.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCreditSchemaItem is the one place dimensions enter: a row with rules is
projected through resolveCreditDimensionRate into an ordinary flat or
graduated item (most specific match sets the rate, every matching
multiplier scales it, no match keeps the row's rate), so the cost math,
rate cards, Lua and SQL stay unchanged. The winning dimension names the
attribution key. Event properties are threaded from the deduction options
through computeCreditCosts and the creditSystemUtils entry points, the
check conversion, and finalize — which previously dropped the receipt's
properties. Dimensioned rows join the fail-closed set and report no single
rate to analytics.
Stack created with GitHub Stacks CLI • Give Feedback 💬
Summary by cubic
Prices track events by credit dimensions: a rate-card row with dimension rules now matches the event's properties, and the most specific match sets the rate (multipliers scale it, no match falls back to the row's rate). The winning dimension names the usage attribution key, and dimensioned rows are fail-closed with no single rate reported to analytics.
Migration
Written for commit 3340807. Summary will update on new commits.