feat(balances): describe the blocking cap on limit_reached - #3249
Merged
charlietlamb merged 8 commits intoSep 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This was referenced Sep 3, 2026
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 12:40
7dea514 to
90b5494
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 12:41
90b5494 to
3fdd89b
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 12:43
3fdd89b to
5f97378
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 12:44
5f97378 to
45006fb
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 12:51
45006fb to
d27cbf9
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 12:53
d27cbf9 to
125daa8
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 13:04
125daa8 to
53928b4
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 13:20
53928b4 to
b978a0b
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
2 times, most recently
from
September 3, 2026 14:10
f1c1a62 to
eb7bb83
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
4 times, most recently
from
September 3, 2026 15:49
1042127 to
924354e
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 15:58
924354e to
6920a1e
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 16:03
6920a1e to
b3c694b
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 16:15
b3c694b to
be41d80
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 16:25
be41d80 to
3f08772
Compare
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 17:17
3f08772 to
c552f5f
Compare
balances.limit_reached carries a usage_limit block (limit, interval, anchor, usage, remaining, window bounds) when a usage limit blocked the event, resolved from the FullSubject the way alerts resolve it. The schema also declares the filter field the payload already sent.
…ared window measurer
charlietlamb
force-pushed
the
charlie/alert-basis-limit-reached
branch
from
September 3, 2026 17:38
c552f5f to
3ecb60e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 5 of 6 (limit_reached). Base: #3248.
balances.limit_reachedcarries ausage_limitblock (limit, interval, anchor, usage, remaining, window bounds) when a usage limit blocked the event, resolved from the FullSubject through the same window-limit helper the alerts use. The schema also declares thefilterfield the payload was already sending.Test:
limit-reached-usage-limit-block.test.ts, green locally.Greptile Summary
The PR expands
balances.limit_reachedso FullSubject-backed usage-limit events describe the blocking cap and its live window.filterandusage_limitfields to the shared webhook schema.Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Track usage] --> B[Evaluate updated subject] B --> C{Usage limit blocked?} C -- No --> D[Emit limit event without usage_limit] C -- Yes --> E[Resolve tracked-feature window limits] E --> F[Select exhausted cap with least headroom] F --> G[Emit matching filter and usage_limit block]Reviews (17): Last reviewed commit: "fix(balances): limit_reached filter alwa..." | Re-trigger Greptile
Context used: