fix build: make parse constexpr for new fmt#1287
Open
Malevrovich wants to merge 1 commit into
Open
Conversation
fmt v11+ uses consteval format string validation (fstring) which requires fmt::formatter::parse() to be a constant expression. The non-constexpr parse() methods in protobuf test utils caused compile errors like: error: call to consteval function 'fmt::fstring<...>' is not a constant expression note: non-constexpr function 'parse' cannot be used in a constant expression Make all 4 parse() methods constexpr and simplify them to return ctx.begin(), matching the existing pattern in http_method.hpp and sockaddr.hpp. The removed runtime throw guard is no longer needed — fmt's compile-time checker now catches invalid format specs at compile time with "unknown format specifier" error.
Contributor
Author
|
LGTM |
|
Many thanks for the PR! @Malevrovich is now importing your pull request into our internal upstream repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmt v11+ uses consteval format string validation (fstring) which requires fmt::formatter::parse() to be a constant expression. The non-constexpr parse() methods in protobuf test utils caused compile errors like:
error: call to consteval function 'fmt::fstring<...>' is not a constant expression
note: non-constexpr function 'parse' cannot be used in a constant expression
Make all 4 parse() methods constexpr and simplify them to return ctx.begin(), matching the existing pattern in http_method.hpp and sockaddr.hpp. The removed runtime throw guard is no longer needed — fmt's compile-time checker now catches invalid format specs at compile time with "unknown format specifier" error.