Skip to content
This repository was archived by the owner on Jun 24, 2026. It is now read-only.

Add deprecation notice pointing to hosted MCP server#205

Merged
kschrader merged 1 commit into
mainfrom
deprecation-notice
Jun 23, 2026
Merged

Add deprecation notice pointing to hosted MCP server#205
kschrader merged 1 commit into
mainfrom
deprecation-notice

Conversation

@kschrader

@kschrader kschrader commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary

This self-hosted Shortcut MCP server is deprecated and no longer maintained. This adds a notice directing users to the official hosted server at https://mcp.shortcut.com/mcp.

  • Prepends the notice to the first successful tool result of each session via the shared CallTool handler in CustomMcpServer — covers both the stdio and HTTP servers, which each create a server instance per session.
  • Errors are left untouched and don't consume the "first call" slot, so the notice survives until a real result is returned.
  • Logs the notice to stderr on stdio server startup (once per process boot).

Testing

  • bun test — 368 pass, 0 fail
  • bun run ts — clean

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Deprecation
    • Self-hosted Shortcut MCP server now marked as deprecated
    • Deprecation warnings displayed at server startup and in tool responses
    • Notice appears once per server session to reduce repetition
    • Users directed to migrate to the hosted MCP endpoint

This self-hosted server is deprecated and no longer maintained. Surface a
notice directing users to the official hosted server at
https://mcp.shortcut.com/mcp:

- Prepend the notice to the first successful tool result of each session
  via the shared CallTool handler in CustomMcpServer (covers both stdio and
  HTTP servers, which each create a server instance per session).
- Log the notice to stderr on stdio server startup.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Two deprecation surfaces are added to the self-hosted MCP server: startServer() now prints a console.error banner at startup, and CustomMcpServer gains a withDeprecationNotice helper that prepends a deprecation text item to the first successful tool response per instance, tracked via a new deprecationNoticeShown flag.

Changes

Deprecation Notices

Layer / File(s) Summary
Startup deprecation banner
src/server.ts
startServer() emits a console.error deprecation message at the top of its try block before transport initialization.
In-band tool response deprecation notice
src/mcp/CustomMcpServer.ts
Adds DEPRECATION_NOTICE constant and deprecationNoticeShown instance flag. Introduces withDeprecationNotice(result) which prepends the notice text to the first successful tool result and passes all subsequent results and errors through unchanged. Tool request handler updated to wrap results through withDeprecationNotice.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 The server waves goodbye with grace,
A notice tucked in first-response space.
"We've moved!" it whispers, once and clear,
Then hops along without more fear.
To hosted lands the bunnies cheer! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main change: adding a deprecation notice that points users to the hosted MCP server, which is the core intent of this PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deprecation-notice

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kschrader kschrader merged commit 10d43bc into main Jun 23, 2026
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant