fix(l10n): complete Korean localization by sampple-korea · Pull Request #1559 · utkarshdalal/GameNative

sampple-korea · 2026-06-09T16:48:48Z

Description

Completes the Korean localization by filling missing Korean string resources and fixing placeholder parity issues in values-ko.

Recording

N/A - resource-only localization update.

Type of Change

Bug fix
Performance / stability improvement
Compatibility improvements
Other (requires prior approval)

Summary

Added missing Korean translations for current base strings.
Fixed Korean placeholder parity for download and storage strings.
Removed stale Korean-only string entries that no longer exist in the base resources.
Preserved product, platform, technical, API, placeholder, and markup terms.
Aligned Korean terminology for frontend and Workshop-related UI labels with nearby existing strings.

Translation notes

Preserved terms such as GameNative, Steam, Bionic Steam, FSR, AMD FidelityFX Super Resolution, EASU, RCAS, CAS, DLS, vkBasalt, DRM, and DLC.
Adapted wording for concise Korean UI usage.
Followed the existing Android values-ko/strings.xml localization structure.

Validation

Verified XML parsing.
Verified base/Korean key parity: 1374 / 1374.
Verified no missing or extra Korean keys.
Verified placeholder parity.
Verified no duplicate Korean string keys.
Ran git diff --check.

Checklist

If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
I have attached a recording of the change.
I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by CodeRabbit

Localization
- Updated Korean UI strings: clearer per-state download counts, improved storage-move error wording, removed obsolete touchscreen/gesture labels.
New Features (UI text)
- Added Korean text for local-saves-only mode, experimental Bionic Steam launch, frontend sync directory confirmations, FSR options (quality/sharpness/notes), renderer/presentation modes, performance HUD battery temp, Wi‑Fi download statuses, many option labels for store, container, DRM, cloud sync, saves, images, DLC/workshop management.

coderabbitai · 2026-06-09T16:49:45Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 62ae2e3b-f8f1-4327-999a-c11454401792

📥 Commits

Reviewing files that changed from the base of the PR and between a12b13f and 4d0a9ab.

📒 Files selected for processing (1)

app/src/main/res/values-ko/strings.xml

🚧 Files skipped from review as they are similar to previous changes (1)

app/src/main/res/values-ko/strings.xml

📝 Walkthrough

Walkthrough

This PR updates Korean UI strings in a single resource file, adding and modifying entries for download summaries, storage migration messages, launch/input options, frontend sync prompts, rendering/FSR controls, and many option labels for game/store/container management.

Changes

Korean Localization Updates

Layer / File(s)	Summary
Download and storage operation strings `app/src/main/res/values-ko/strings.xml`	`downloads_summary` changed to a three-count progress summary using `%1$d`, `%2$d`, `%3$d`; `container_storage_move_failed` now uses two arguments with reordered placeholders.
Launch options and input control strings `app/src/main/res/values-ko/strings.xml`	Adds `local_saves_only` and `local_saves_only_description`, updates `launch_bionic_steam` and its description, and removes `touchscreen_mode_description` and `gesture_settings` while keeping shooter-mode labels grouped under touchscreen controls.
Rendering features and comprehensive UI option labels `app/src/main/res/values-ko/strings.xml`	Adds `screen_effects_scaling_mode`, FSR 1.0 strings (quality/sharpness and launch-sharpness note), frontend sync directory-picker confirmations (`frontend_sync_pick_directory_cd`, `frontend_sync_clear_directory_cd`), Wi‑Fi download status messages, `main_downloading_entry`, `tools_wine_processes_empty`, `performance_hud_battery_temperature`, `renderer_present_modes`, `settings_emulation_auto_apply_known_config_`, and many `option_` labels for store/container/DRM/verification/update/storage/cloud/save/image/graphics/workshop/DLC actions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

utkarshdalal/GameNative#1315: Adds/aligned similar i18n UI strings (e.g., local_saves_only, main_downloading_entry, FSR/scaling) in another locale.
utkarshdalal/GameNative#512: Also updates values-ko/strings.xml with overlapping Korean UI string changes.
utkarshdalal/GameNative#1349: Enables Korean locale in the in-app language switcher, related to selection of ko resources.

Suggested reviewers

utkarshdalal
phobos665

Poem

🐰 Korean keys sprouted, tidy and bright,
Counts for downloads now show up just right,
Local saves and Bionic Steam take flight,
FSR sharpens, render labels in sight,
Strings hop along — localization delight! 🎮✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(l10n): complete Korean localization' directly and concisely describes the main change—completing Korean localization by adding missing translations and fixing issues.
Description check	✅ Passed	The description covers all critical sections: what changed (missing translations, placeholder fixes, removed stale entries), validation steps performed, and alignment with project scope, though recording checkbox remains unchecked due to resource-only nature.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates Korean (values-ko) Android string resources to reflect new/changed UI text and newly added settings/options.

Changes:

Updated existing strings to include formatted counts and richer error details.
Added new strings for cloud-save controls, scaling/FSR settings, frontend sync actions, and various context menu options.
Removed a couple of Korean-only string entries (likely reflecting UI/feature changes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sampple-korea · 2026-06-09T17:04:13Z

    <string name="container_storage_move_external_disabled">게임을 이동하기 전에 설정에서 외부 저장소 경로를 지정하세요.</string>
    <string name="container_storage_move_success">%1$s을(를) %2$s(으)로 이동했습니다</string>
-    <string name="container_storage_move_failed">게임 이동 실패: %1$s</string>
+    <string name="container_storage_move_failed">%1$s 이동 실패: %2$s</string>


Verified the call site in ContainerStorageManagerDialog.kt: it passes both entryName and the failure reason/fallback string to container_storage_move_failed, so the two placeholders are covered.

sampple-korea · 2026-06-09T17:04:14Z

    <string name="touchscreen_mode">터치스크린 모드</string>
-    <string name="touchscreen_mode_description">비주얼 노벨 및 RTS 게임용</string>
    <string name="shooter_mode_toggle">슈터 모드</string>


Verified this against the base resources and code usage. These two IDs no longer exist in values/strings.xml, and the code uses gesture_settings_title; keeping Korean-only entries would leave stale extra keys.

sampple-korea · 2026-06-09T17:04:16Z


    <!-- Gesture Settings Dialog -->
-    <string name="gesture_settings">제스처 설정</string>
    <string name="gesture_settings_title">터치 제스처 설정</string>


Same verification as above: the base locale no longer defines these IDs and code references gesture_settings_title, so removing the stale Korean-only entries keeps key parity with the base resources.

sampple-korea · 2026-06-09T17:04:18Z

+    <string name="download_paused_wifi">다운로드 일시 중지됨 - Wi-Fi 또는 LAN 연결 대기 중</string>
+    <string name="main_downloading_entry">%s 다운로드 중</string>
+    <string name="option_open_store_page">상점 페이지 열기</string>
+    <string name="option_export_for_frontend">frontend용으로 내보내기</string>


Fixed in 4d0a9ab by changing this to 프론트엔드용으로 내보내기 to match nearby Korean frontend sync strings.

sampple-korea · 2026-06-09T17:04:20Z

+    <string name="option_fetch_game_images">게임 이미지 가져오기</string>
+    <string name="option_test_graphics">그래픽 테스트</string>
+    <string name="option_manage_dlc">DLC 관리</string>
+    <string name="option_manage_workshop">Workshop 관리</string>


Fixed in 4d0a9ab by changing this to 워크숍 관리, matching the existing Korean Workshop strings in this file.

cubic-dev-ai

No issues found across 1 file

_{Re-trigger cubic}

fix(l10n): complete Korean localization

a12b13f

sampple-korea requested a review from utkarshdalal as a code owner June 9, 2026 16:48

Copilot AI review requested due to automatic review settings June 9, 2026 16:48

Copilot AI reviewed Jun 9, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Jun 9, 2026

View reviewed changes

fix(l10n): align Korean UI terminology

4d0a9ab

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(l10n): complete Korean localization#1559

fix(l10n): complete Korean localization#1559
sampple-korea wants to merge 2 commits into
utkarshdalal:masterfrom
sampple-korea:feat/korean-localization

sampple-korea commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

sampple-korea Jun 9, 2026 •

edited

Loading

Uh oh!

sampple-korea Jun 9, 2026 •

edited

Loading

Uh oh!

sampple-korea Jun 9, 2026

Uh oh!

sampple-korea Jun 9, 2026

Uh oh!

sampple-korea Jun 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sampple-korea commented Jun 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Recording

Type of Change

Summary

Translation notes

Validation

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

sampple-korea Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sampple-korea Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sampple-korea Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

sampple-korea Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

sampple-korea Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sampple-korea commented Jun 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

sampple-korea Jun 9, 2026 •

edited

Loading

sampple-korea Jun 9, 2026 •

edited

Loading