fix: refactor pulseaudio sink implementation to auto failover#1560
fix: refactor pulseaudio sink implementation to auto failover#1560joshuatam wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughUpdated the PulseAudio component archive version reference in ChangesPulseAudio Component Asset Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt`:
- Line 4506: PulseAudio runtime paths are constructed with new
File(context.getFilesDir(), "/pulseaudio") (PulseAudioComponent, occurrences
around lines ~259/302/345) which yields an absolute "/pulseaudio" path, while
XServerScreen.kt extracts the archive into File(context.filesDir, "pulseaudio")
(<filesDir>/pulseaudio); fix by normalizing the runtime path to match the
extraction target: change the child path from "/pulseaudio" to "pulseaudio" in
PulseAudioComponent so it uses new File(context.getFilesDir(), "pulseaudio") (or
otherwise build the path via File(context.filesDir, "pulseaudio")) ensuring
/pulseaudio is not treated as an absolute path and the extracted pactl/modules
and generated default.pa are found.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2fa2cbb4-96de-47bc-923c-8a541a17bdb8
📒 Files selected for processing (3)
app/src/main/assets/pulseaudio-gamenative-20260609.tzstapp/src/main/assets/pulseaudio-gamenative-20260610.tzstapp/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
Description
fix: refactor pulseaudio sink implementation to auto failover
Recording
None
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by CodeRabbit