-
Notifications
You must be signed in to change notification settings - Fork 8
fix(bitbucket): name a project when the workspace won't pick one #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
62e8fff
fix(bitbucket): name a project when the workspace won't pick one
HarshMN2345 0fd9b98
feat(bitbucket): take the project a repository belongs to
HarshMN2345 0cfd652
fix(bitbucket): read the project lookup the way the rest of the file …
HarshMN2345 ce1c834
refactor(bitbucket): let the workspace say it needs a project
HarshMN2345 fd7f0d9
test(bitbucket): cover the project a repository is created in
HarshMN2345 ee6922f
test(bitbucket): expect an unknown project to be refused
HarshMN2345 7496330
refactor(bitbucket): keep the project off the shared contract
HarshMN2345 16b6af2
test(bitbucket): cover creating with, without and against an unknown …
HarshMN2345 f397ec7
test(bitbucket): walk both project scenarios in one test
HarshMN2345 0c88b47
test(bitbucket): read the project key where it is asserted
HarshMN2345 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,7 +91,7 @@ protected function generateAccessToken(string $privateKey, string $appId): void | |
| * | ||
| * @return array<mixed> Details of new repository | ||
| */ | ||
| public function createRepository(string $owner, string $repositoryName, bool $private): array | ||
| public function createRepository(string $owner, string $repositoryName, bool $private, string $project = ''): array | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets not add project to all adapters, unless we know it is a feature. If project is bitbucket specific concept, we need to keep it bitbucket only |
||
| { | ||
| $url = "/orgs/{$owner}/repos"; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.