uucore: remove process functions - #11158
Open
xtqqczze wants to merge 1 commit into
Open
Conversation
Contributor
|
are you sure it isn't used by other consumers of uucore ? |
This comment was marked as resolved.
This comment was marked as resolved.
|
GNU testsuite comparison: |
xtqqczze
marked this pull request as draft
February 28, 2026 14:59
Contributor
|
@xtqqczze still draft, no ? :) |
xtqqczze
marked this pull request as ready for review
May 17, 2026 01:28
xtqqczze
marked this pull request as draft
May 17, 2026 02:17
xtqqczze
force-pushed
the
rm-getpid
branch
5 times, most recently
from
May 17, 2026 02:32
2c77483 to
b6bb40e
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
|
GNU testsuite comparison: |
xtqqczze
force-pushed
the
rm-getpid
branch
5 times, most recently
from
May 17, 2026 11:34
b94021b to
3203759
Compare
xtqqczze
marked this pull request as ready for review
May 17, 2026 11:34
Contributor
|
This is one of a large disadvantage of public thin wrappers... |
xtqqczze
force-pushed
the
rm-getpid
branch
2 times, most recently
from
May 21, 2026 02:21
0d2fe83 to
d51abb5
Compare
Contributor
|
@sylvestre I'd like to have this before #13006 |
xtqqczze
force-pushed
the
rm-getpid
branch
2 times, most recently
from
July 16, 2026 09:41
51f6d77 to
7af67ab
Compare
Contributor
|
Conflicting |
xtqqczze
force-pushed
the
rm-getpid
branch
3 times, most recently
from
August 29, 2026 11:55
1db6381 to
2185cbd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
xtqqczze
marked this pull request as draft
August 31, 2026 11:04
xtqqczze
force-pushed
the
rm-getpid
branch
12 times, most recently
from
September 1, 2026 10:19
54b0b7a to
03fdd1c
Compare
xtqqczze
marked this pull request as ready for review
September 1, 2026 16:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12342
Remove the wrapper functions from
uucore::processand userustixdirectly in each crate.The last downstream consumer of these APIs was removed in uutils/procps#701.
In any case, migrating downstream users to
rustixis straightforward, as the wrappers provide only a thin abstraction over the underlying process APIs.