Skip to content

uucore: remove process functions - #11158

Open
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:rm-getpid
Open

uucore: remove process functions#11158
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:rm-getpid

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

Closes #12342

Remove the wrapper functions from uucore::process and use rustix directly in each crate.

The last downstream consumer of these APIs was removed in uutils/procps#701.

In any case, migrating downstream users to rustix is straightforward, as the wrappers provide only a thin abstraction over the underlying process APIs.

@sylvestre

Copy link
Copy Markdown
Contributor

are you sure it isn't used by other consumers of uucore ?

@xtqqczze

This comment was marked as resolved.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Congrats! The gnu test tests/timeout/timeout-group is no longer failing!
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@xtqqczze
xtqqczze marked this pull request as draft February 28, 2026 14:59
@sylvestre

Copy link
Copy Markdown
Contributor

@xtqqczze still draft, no ? :)

@xtqqczze
xtqqczze marked this pull request as ready for review May 17, 2026 01:28
@xtqqczze xtqqczze changed the title uucore: remove unused getpid and getsid functions uucore: remove process functions May 17, 2026
@xtqqczze
xtqqczze marked this pull request as draft May 17, 2026 02:17
@xtqqczze
xtqqczze force-pushed the rm-getpid branch 5 times, most recently from 2c77483 to b6bb40e Compare May 17, 2026 02:32
@codspeed-hq

codspeed-hq Bot commented May 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 139 untouched benchmarks
⏩ 272 skipped benchmarks1


Comparing xtqqczze:rm-getpid (60cd47e) with main (b7519db)

Open in CodSpeed

Footnotes

  1. 272 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented May 17, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/cp/parent-perm-race. tests/cp/parent-perm-race is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.

@xtqqczze
xtqqczze force-pushed the rm-getpid branch 5 times, most recently from b94021b to 3203759 Compare May 17, 2026 11:34
@xtqqczze
xtqqczze marked this pull request as ready for review May 17, 2026 11:34
@oech3

oech3 commented May 19, 2026

Copy link
Copy Markdown
Contributor

This is one of a large disadvantage of public thin wrappers...

@xtqqczze
xtqqczze force-pushed the rm-getpid branch 2 times, most recently from 0d2fe83 to d51abb5 Compare May 21, 2026 02:21
@oech3

oech3 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@sylvestre I'd like to have this before #13006

@xtqqczze
xtqqczze force-pushed the rm-getpid branch 2 times, most recently from 51f6d77 to 7af67ab Compare July 16, 2026 09:41
@oech3

oech3 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Conflicting

@xtqqczze
xtqqczze force-pushed the rm-getpid branch 3 times, most recently from 1db6381 to 2185cbd Compare August 29, 2026 11:55
@xtqqczze

This comment was marked as outdated.

@xtqqczze
xtqqczze marked this pull request as draft August 31, 2026 11:04
@xtqqczze
xtqqczze force-pushed the rm-getpid branch 12 times, most recently from 54b0b7a to 03fdd1c Compare September 1, 2026 10:19
@xtqqczze
xtqqczze marked this pull request as ready for review September 1, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants