fix(truncate): implement --io-blocks - #13432
Merged
Merged
Conversation
|
GNU testsuite comparison: |
ThomasHabets
force-pushed
the
truncate-blocks
branch
from
July 19, 2026 11:18
07e75dc to
4d6b8c2
Compare
ThomasHabets
force-pushed
the
truncate-blocks
branch
from
July 19, 2026 11:42
4d6b8c2 to
a249821
Compare
ThomasHabets
marked this pull request as draft
July 19, 2026 12:03
Merging this PR will not alter performance
Comparing Footnotes
|
ThomasHabets
force-pushed
the
truncate-blocks
branch
4 times, most recently
from
August 28, 2026 12:26
a3b2fb2 to
8e1a17d
Compare
Contributor
|
Looks good |
Contributor
Author
|
Not sure what this means. Is it a false positive? I seem to be rebased correctly on top of HEAD |
ThomasHabets
marked this pull request as ready for review
August 28, 2026 13:11
Contributor
|
@ThomasHabets yes, it's a false positive. |
Scale SIZE by the preferred I/O block size of each output file, using the parent filesystem for files that do not exist yet. Before: `truncate --io-blocks --size=1 a` file produced a 1-byte file. After: The same command produces a 4096-byte file on a filesystem with 4096-byte I/O blocks.
cakebaker
force-pushed
the
truncate-blocks
branch
from
September 2, 2026 14:05
8e1a17d to
f0d576b
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scale SIZE by the preferred I/O block size of each output file, using the parent filesystem for files that do not exist yet.
Before
truncate --io-blocks --size=1file produced a 1-byte file.After
The same command produces a 4096-byte file on a filesystem with 4096-byte I/O blocks.